Review Request: fix kcombobox memory leak

[Jaime Torres]

I will not commit, but I think there is a memleak in Qt 4.6.0.


==6159== 85,091 (240 direct, 84,851 indirect) bytes in 1 blocks are definitely lost in loss record 658 of 659
==6159==    at 0x4C249AF: operator new(unsigned long) (vg_replace_malloc.c:220)
==6159==    by 0x7DF2CA4: QFontDatabase::load(QFontPrivate const*, int) (qfontdatabase.cpp:997)
==6159==    by 0x7DCA8DF: QFontPrivate::engineForScript(int) const (qfont.cpp:270)
==6159==    by 0x7E020FB: QScriptLine::setDefaultHeight(QTextEngine*) (qtextengine.cpp:2013)
==6159==    by 0x7E0E736: QTextLine::layout_helper(int) (qtextlayout.cpp:1713)
==6159==    by 0x7E10845: QTextLayout::endLayout() (qtextlayout.cpp:625)
==6159==    by 0x7FB474F: QLineControl::updateDisplayText() (qlinecontrol.cpp:102)
==6159==    by 0x7FB4B44: QLineControl::init(QString const&) (qlinecontrol.cpp:292)
==6159==    by 0x7FACD10: QLineEditPrivate::init(QString const&) (qlinecontrol_p.h:89)
==6159==    by 0x7FB0911: QLineEdit::QLineEdit(QWidget*) (qlineedit.cpp:266)
==6159==    by 0x5F35E5D: KLineEdit::KLineEdit(QWidget*) (klineedit.cpp:206)
==6159==    by 0x5F1665D: KComboBox::setEditable(bool) (kcombobox.cpp:396)



On Sábado 19 Diciembre 2009 13:34:58 Christoph Feck escribió:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2416/#review3455
> -----------------------------------------------------------
> 
> 
> Please do not apply this patch.
> 
> KComboBox::setLineEdit() calls QComboBox::setLineEdit(), and as documented,
>  that takes ownership, so it will be deleted automatically.
> 
> And I doubt it could help fixing mentioned bug, which speaks of leaks in
>  kdeinit (and they probably aren't leaks, but just growing VM size due to
>  fragmentation).
> 
> - Christoph
> 
> On 2009-12-19 12:11:20, Jaime Torres wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/2416/
> > -----------------------------------------------------------
> >
> > (Updated 2009-12-19 12:11:20)
> >
> >
> > Review request for kdelibs.
> >
> >
> > Summary
> > -------
> >
> > Fixes the last memory leak that KDE can remove.
> > (as always, I've removed the spaces at the end after looking the red
> > boxes in the diff view)
> >
> >
> > This addresses bug 88550.
> >     https://bugs.kde.org/show_bug.cgi?id=88550
> >
> >
> > Diffs
> > -----
> >
> >   /trunk/KDE/kdelibs/kdeui/widgets/kcombobox.cpp 1063847
> >
> > Diff: http://reviewboard.kde.org/r/2416/diff
> >
> >
> > Testing
> > -------
> >
> > valgrind does not show any kde memory leak in kfind.
> >
> >
> > Thanks,
> >
> > Jaime
>