[PATCH] New image loader (Softimage PIC)
Esben Mose Hansen
kde at mosehansen.dk
Sat Dec 19 08:48:28 GMT 2009
On Friday 18 December 2009 22:06:12 David Faure wrote:
> Not much to say about the image loader itself (except that it could
> follow the kdelibs coding style a bit more, especially the if+return in
> one line hurts readability given that we're not used to that).
>
More than just readability, it is hard to set breakpoints in constructs like
that. That is why I always suggest a newline before the block in if, even if
it is just one short line.
(We don't really do that here, but always using {} in if blocks is also a good
idea, in my not-so-humble opinion).
--
Kind regards, Esben
More information about the kde-core-devel
mailing list