Please review: php & php-docs plugins for KDevplatform

[Pino Toscano]

Alle giovedì 17 dicembre 2009, Burkhard Lück ha scritto:
> Am Donnerstag, 17. Dezember 2009 21:49:02 schrieb Milian Wolff:
> > Burkhard Lück, 17.12.2009:
> > > Am Donnerstag, 17. Dezember 2009 21:25:35 schrieb Milian Wolff:
> > > > Hello all!
> > > >
> > > > Niko Sams and me want to get our plugins for KDevplatform, that bring
> > > > PHP support, to extragear. Hence, please review them. They are now in
> > > > kdereview.
> > > >
> > > > There is no docbook manual, though imo most of that should be
> > > > documented for KDevelop itself (mostly just implementing interfaces
> > > > and providing general features).
> > > >
> > > > Afaik there should be no Krazy issues left (checked last time one or
> > > > two weeks ago).
> > > >
> > > > So, please give me your feedback, tips and tricks. I'll gladly
> > > > implement them.
> > >
> > > phplanguagesupport.cpp:58:K_EXPORT_PLUGIN(KDevPhpSupportFactory("kdevph
> > >ps up port")) Messages.sh extracts to catalog "kdevphp"
> > >
> > > "kdevphp" != "kdevphpsupport" -> untranslated :(
> >
> > So is it OK if I just change the Messages.sh file? I.e.:
> >
> > $XGETTEXT `find . -name \*.cc -o -name \*.cpp -o -name \*.h` -o
> > $podir/kdevphpsupport.pot
> >
> > That should fix this, right?
> 
> Yes.
> 
> And the existing translations have to be renamed as well, that can be done
> moving them to l10n-kde4/*/messages/kdereview.

Or, instead of the usual move mess, just add "kdevphp" as second parameter to 
the factory (which is simplier).

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20091217/4e68a080/attachment.sig>