Please review: php & php-docs plugins for KDevplatform

[Burkhard Lück]

Am Donnerstag, 17. Dezember 2009 22:04:34 schrieb Milian Wolff:
> Milian Wolff, 17.12.2009:
> > Burkhard Lück, 17.12.2009:
> > > Am Donnerstag, 17. Dezember 2009 21:25:35 schrieb Milian Wolff:
> > > > Hello all!
> > > >
> > > > Niko Sams and me want to get our plugins for KDevplatform, that bring
> > > > PHP support, to extragear. Hence, please review them. They are now in
> > > > kdereview.
> > > >
> > > > There is no docbook manual, though imo most of that should be
> > > > documented for KDevelop itself (mostly just implementing interfaces
> > > > and providing general features).
> > > >
> > > > Afaik there should be no Krazy issues left (checked last time one or
> > > > two weeks ago).
> > > >
> > > > So, please give me your feedback, tips and tricks. I'll gladly
> > > > implement them.
> > >
> > > phplanguagesupport.cpp:58:K_EXPORT_PLUGIN(KDevPhpSupportFactory("kdevph
> > >ps up port")) Messages.sh extracts to catalog "kdevphp"
> > >
> > > "kdevphp" != "kdevphpsupport" -> untranslated :(
> >
> > So is it OK if I just change the Messages.sh file? I.e.:
> >
> > $XGETTEXT `find . -name \*.cc -o -name \*.cpp -o -name \*.h` -o
> > $podir/kdevphpsupport.pot
> >
> > That should fix this, right?
> 
> Oh, and I'll just copy this file for php-docs and adapt the catalog, that's
>  all for translations, right?
> 
That is not sufficient, in php-docs are some *.ui and *.kcfg files. To extract 
messages from these files too you have to use extractrc, see:
http://techbase.kde.org/Development/Tutorials/Localization/i18n_Build_Systems#Extracting_the_strings

-- 
Burkhard Lück