Review Request: Split kcm_desktoppaths from konqueror settings

[Christoph Feck]

> On 2009-12-08 08:32:57, Burkhard Lück wrote:
> > It is no problem to move the documentation and all translations, so I'd prefer the "correct fix" moving the code to kdebase/runtime and remove the desktopath page from konquerors settings dialog. This kcm module is already accessible in Systemsettings->General->Personal->About Me.

Could you help me move the doc/translations after I moved the code? Can this be done for 4.4, or would that mess current translation procedure?


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2336/#review3389
-----------------------------------------------------------


On 2009-12-08 03:41:11, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2336/
> -----------------------------------------------------------
> 
> (Updated 2009-12-08 03:41:11)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch splits the desktop paths settings page into its own plugin.
> 
> The correct fix would be to move that to kdebase/runtime, but I have no idea how that can be done without breaking doc/translations, but at least this allows packagers to move the desktoppaths out of the konqueror package (see bug report).
> 
> 
> This addresses bug 216427.
>     https://bugs.kde.org/show_bug.cgi?id=216427
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konq/CMakeLists.txt 1057395 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konq/desktoppath.desktop 1057395 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konq/globalpaths.cpp 1057395 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konq/kcmdesktoppaths.h PRE-CREATION 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konq/kcmdesktoppaths.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/apps/konqueror/settings/konq/konqkcmfactory.cpp 1057395 
> 
> Diff: http://reviewboard.kde.org/r/2336/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph
> 
>