Review Request: Fix solid brightness control initialization

nweibley at gmail.com nweibley at gmail.com
Sun Dec 13 15:05:57 GMT 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2368/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Fixes implicit typecast from previous commit to halpower.cpp and addresses a new bug precipitated by hal-0.5.14 in which the battery plasmoid unconditionally reset screen brightness to 0


This addresses bugs 196232 and 217316.
    https://bugs.kde.org/show_bug.cgi?id=196232
    https://bugs.kde.org/show_bug.cgi?id=217316


Diffs
-----

  /trunk/KDE/kdebase/workspace/libs/solid/control/powermanager.cpp 1062002 
  /trunk/KDE/kdebase/workspace/solid/hal/halpower.cpp 1062002 

Diff: http://reviewboard.kde.org/r/2368/diff


Testing
-------

Tested against hal-0.5.13 and hal-0.5.14 on Gentoo X86_64, kernel 2.6.32, kde-4.3.4, qt-4.6.


Thanks,

nweibley





More information about the kde-core-devel mailing list