Review Request: some krazy (and cppcheck) cleanups
Andrew Coles
andrew_coles at yahoo.co.uk
Wed Dec 9 19:15:32 GMT 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2321/#review3396
-----------------------------------------------------------
Does the example compile? You declared repository_itEnd but then referred to repository_itEmd.
- Andrew
On 2009-12-09 18:35:46, Jaime Torres wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2321/
> -----------------------------------------------------------
>
> (Updated 2009-12-09 18:35:46)
>
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> c++ style casts
> ++c increments
> variable initializations
> variable scope
> (The red spaces are already removed from my local copy).
>
>
> Diffs
> -----
>
> /trunk/kdesupport/strigi/src/streamanalyzer/fieldpropertiesdb.cpp 1060267
> /trunk/kdesupport/strigi/src/streams/zipinputstream.cpp 1060267
> /trunk/kdesupport/strigi/src/strigicmd/strigicmd.cpp 1060267
> /trunk/kdesupport/strigi/src/xmlindexer/rdfindexer.cpp 1060267
> /trunk/kdesupport/strigi/src/xsd/example.cpp 1060267
> /trunk/kdesupport/strigi/src/xsd/metadataproperties.cpp 1060267
> /trunk/kdesupport/strigi/src/xsd/strigidaemonconfiguration.cpp 1060267
>
> Diff: http://reviewboard.kde.org/r/2321/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jaime
>
>
More information about the kde-core-devel
mailing list