Review Request: Honor Charset key in web shortcuts

David Faure faure at kde.org
Wed Aug 26 12:46:12 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1396/#review2152
-----------------------------------------------------------

Ship it!


Looks good, good fix.

- David


On 2009-08-24 23:09:53, Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1396/
> -----------------------------------------------------------
> 
> (Updated 2009-08-24 23:09:53)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> currently the Charset key in web shortcuts is ignored and assumed to be UTF-8, with this patch it is used again
> There should be no change for UTF-8 providers and ones that do not specify a charset
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kuriikwsfiltereng.h 1015160 
>   trunk/KDE/kdebase/runtime/kurifilter-plugins/ikws/kuriikwsfiltereng.cpp 1015160 
> 
> Diff: http://reviewboard.kde.org/r/1396/diff
> 
> 
> Testing
> -------
> 
> grec:b├║stia works, doesn't work without it
> imdb:ghost busters still works
> 
> 
> Thanks,
> 
> Albert
> 
>





More information about the kde-core-devel mailing list