Review Request: KPixmapSequence: painting spinners made easy

[Sebastian Trueg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1345/
-----------------------------------------------------------

(Updated 2009-08-25 10:26:19.172527)


Review request for kdelibs.


Changes
-------

* only update pixmap rect
* no need to handle hide/show events in the widget anymore. the painter takes care of that.


Summary
-------

Showing a spinner to indicate a work in progrss is a typical task. Gwenview does have a nice spinner when loading images. Aurelien and I extracted the code from Gwenview and molded it into three nice classes that allow to create spinners very easily in any situation. At the moment the classes are used in Gwenview and in Nepomuk.

KPixmapSequence: a simple container class that loads a sequence of pixmaps and provides the frames through a simple interface.
KPixmapSequenceOverlayPainter: Installs an event filter to paint a KPixmapSequence onto any widget using Qt::Alignment or a relative placement.
KPixmapSequenceWidget: A simple widget using the overlay painter to draw a spinner while the widget is visible.

We propose an addition to kdeui.


Diffs (updated)
-----

  trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1013393 
  trunk/KDE/kdelibs/kdeui/tests/CMakeLists.txt 1013393 
  trunk/KDE/kdelibs/kdeui/tests/kpixmapsequenceoverlaypaintertest.h PRE-CREATION 
  trunk/KDE/kdelibs/kdeui/tests/kpixmapsequenceoverlaypaintertest.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kdeui/util/kpixmapsequence.h PRE-CREATION 
  trunk/KDE/kdelibs/kdeui/util/kpixmapsequence.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kdeui/util/kpixmapsequenceoverlaypainter.h PRE-CREATION 
  trunk/KDE/kdelibs/kdeui/util/kpixmapsequenceoverlaypainter.cpp PRE-CREATION 
  trunk/KDE/kdelibs/kdeui/util/kpixmapsequencewidget.h PRE-CREATION 
  trunk/KDE/kdelibs/kdeui/util/kpixmapsequencewidget.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/1345/diff


Testing
-------


Thanks,

Sebastian