Review Request: remove 8 warnings from kpixmapcache

[Michael Pyne]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1392/#review2138
-----------------------------------------------------------

Ship it!


I find the warnings amusing given that (as far as I know) this (foo = { 0 }) is a fairly standard C++ idiom for forcing struct members to be default initialized instead of left undefined without having to specify each parameter.  I think the reason I didn't declare it this way when I was in here a year ago was because of compilation issues with the char[] buffer, but that could just be poor memory talking.  The patch itself looks good to me.

- Michael


On 2009-08-24 16:15:14, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1392/
> -----------------------------------------------------------
> 
> (Updated 2009-08-24 16:15:14)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> warnings before:
> 
> kdelibs/kdeui/util/kpixmapcache.cpp: In member function ‘bool KPixmapCache::recreateCacheFiles()’:
> kdelibs/kdeui/util/kpixmapcache.cpp:1198: warning: missing braces around initializer for ‘char [21]’
> kdelibs/kdeui/util/kpixmapcache.cpp:1198: warning: missing initializer for member ‘<unnamed>::KPixmapCacheIndexHeader::cacheVersion’
> kdelibs/kdeui/util/kpixmapcache.cpp:1198: warning: missing initializer for member ‘<unnamed>::KPixmapCacheIndexHeader::size’
> kdelibs/kdeui/util/kpixmapcache.cpp:1198: warning: missing initializer for member ‘<unnamed>::KPixmapCacheIndexHeader::cacheId’
> kdelibs/kdeui/util/kpixmapcache.cpp:1198: warning: missing initializer for member ‘<unnamed>::KPixmapCacheIndexHeader::timestamp’
> kdelibs/kdeui/util/kpixmapcache.cpp:1220: warning: missing braces around initializer for ‘char [21]’
> kdelibs/kdeui/util/kpixmapcache.cpp:1220: warning: missing initializer for member ‘<unnamed>::KPixmapCacheDataHeader::cacheVersion’
> kdelibs/kdeui/util/kpixmapcache.cpp:1220: warning: missing initializer for member ‘<unnamed>::KPixmapCacheDataHeader::size’
> 
> warnings after:
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/util/kpixmapcache.cpp 1014718 
> 
> Diff: http://reviewboard.kde.org/r/1392/diff
> 
> 
> Testing
> -------
> 
> With a new user, the icons works as before.
> 
> 
> Thanks,
> 
> Jaime
> 
>