Patch KProtocolManager::defaultUserAgent...

Dawit A. adawit at
Wed Aug 19 15:17:21 BST 2009

On Wednesday 19 August 2009 05:28:01 you wrote:
> On Monday 17 August 2009, Dawit A. wrote:
> > Attached patch changes the language sent as part of the defaultUserAgent
> > string to only the current default language. There is no need to send a
> > list like we do in HTTP's Accept-Language header.
> Can you elaborate? Why the change, what does it fix?
> RFC 2616 section 14.4 does show that passing a list of languages
> in Accept-Language is perfectly acceptable. What seems to be missing
> is the use of quality values like "en;q=0.7" to make sure the user
> preferences are evaluated in the right order (*). But certainly replacing
> the list of languages with a single language seems wrong, for those users
> who have set up a list of preferred languages with fallbacks.
> (*) from the RFC:
> "If no Accept-Language header is present in the request, the server SHOULD
> assume that all languages are equally acceptable."
> That's not what we want, we want that the first language has priority over
> the second, etc. So IMHO the fix is to add q=0.9 to the 2nd language, q=0.8
> to the 3rd one, etc.

I think you misunderstood... I am not advocating changing what is sent by the 
Accept-Language HTTP header at all. That is done correctly. No, What I am 
saying is that "the language type" included in default user-agent string does 
not need to contain what we send through Accept-Language header at all. No 
other browser does if you look at the user-agent string they produce. That is 

More information about the kde-core-devel mailing list