Review Request: Remove some warnings when compiled with: ADD_DEFINITIONS( -Wall -Wextra -Weffc++ -Wstrict-null-sentinel -Wabi -Wreorder -Woverloaded-virtual)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1327/#review2084
-----------------------------------------------------------

Ship it!


Please apply the kgzipfilter.cpp patch, good and useful.

The kfilterdev patch is rather useless, I don't see the point in committing it. -Weffc++ is too strict for its own good.

- David


On 2009-08-16 10:14:13, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1327/
> -----------------------------------------------------------
> 
> (Updated 2009-08-16 10:14:13)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Remove some warnings when compiled with: ADD_DEFINITIONS( -Wall -Wextra -Weffc++ -Wstrict-null-sentinel -Wabi -Wreorder -Woverloaded-virtual)
> 
> Before (removed some noise):
> kdelibs/kdecore/compression/kfilterdev.h: At global scope:
> kdelibs/kdecore/compression/kfilterdev.h:37: warning: ‘class KFilterDev’ has pointer data members
> kdelibs/kdecore/compression/kfilterdev.h:37: warning:   but does not override ‘KFilterDev(const KFilterDev&)’
> kdelibs/kdecore/compression/kfilterdev.h:37: warning:   or ‘operator=(const KFilterDev&)’
> kdelibs/kdecore/compression/kfilterdev.cpp: At global scope:
> kdelibs/kdecore/compression/kfilterdev.cpp:30: warning: ‘class KFilterDev::Private’ has pointer data members
> kdelibs/kdecore/compression/kfilterdev.cpp:30: warning:   but does not override ‘KFilterDev::Private(const KFilterDev::Private&)’
> kdelibs/kdecore/compression/kfilterdev.cpp:30: warning:   or ‘operator=(const KFilterDev::Private&)’
> kdelibs/kdecore/compression/kfilterdev.cpp: In constructor ‘KFilterDev::Private::Private()’:
> kdelibs/kdecore/compression/kfilterdev.cpp:32: warning: ‘KFilterDev::Private::buffer’ should be initialized in the member initialization list
> kdelibs/kdecore/compression/kfilterdev.cpp:32: warning: ‘KFilterDev::Private::origFileName’ should be initialized in the member initialization list
> kdelibs/kdecore/compression/kfilterdev.cpp:32: warning: ‘KFilterDev::Private::result’ should be initialized in the member initialization list
> kdelibs/kdecore/compression/kfilterdev.cpp:32: warning: ‘KFilterDev::Private::filter’ should be initialized in the member initialization list
> 
> kdelibs/kdecore/compression/kgzipfilter.h:33: warning: ‘class KGzipFilter’ has pointer data members
> kdelibs/kdecore/compression/kgzipfilter.h:33: warning:   but does not override ‘KGzipFilter(const KGzipFilter&)’
> kdelibs/kdecore/compression/kgzipfilter.h:33: warning:   or ‘operator=(const KGzipFilter&)’
> kdelibs/kdecore/compression/kgzipfilter.cpp: In constructor ‘KGzipFilter::Private::Private()’:
> kdelibs/kdecore/compression/kgzipfilter.cpp:41: warning: ‘KGzipFilter::Private::zStream’ should be initialized in the member initialization list
> kdelibs/kdecore/compression/kgzipfilter.cpp:41: warning: ‘KGzipFilter::Private::headerWritten’ should be initialized in the member initialization list
> kdelibs/kdecore/compression/kgzipfilter.cpp:41: warning: ‘KGzipFilter::Private::footerWritten’ should be initialized in the member initialization list
> kdelibs/kdecore/compression/kgzipfilter.cpp:41: warning: ‘KGzipFilter::Private::compressed’ should be initialized in the member initialization list
> kdelibs/kdecore/compression/kgzipfilter.cpp:41: warning: ‘KGzipFilter::Private::mode’ should be initialized in the member initialization list
> kdelibs/kdecore/compression/kgzipfilter.cpp:41: warning: ‘KGzipFilter::Private::crc’ should be initialized in the member initialization list
> 
> After (removed the same noise):
> kdelibs/kdecore/compression/kfilterdev.h: At global scope:
> kdelibs/kdecore/compression/kfilterdev.h:37: warning: ‘class KFilterDev’ has pointer data members
> kdelibs/kdecore/compression/kfilterdev.h:37: warning:   but does not override ‘KFilterDev(const KFilterDev&)’
> kdelibs/kdecore/compression/kfilterdev.h:37: warning:   or ‘operator=(const KFilterDev&)’
> kdelibs/kdecore/compression/kfilterdev.cpp:30: warning: ‘class KFilterDev::Private’ has pointer data members
> kdelibs/kdecore/compression/kfilterdev.cpp:30: warning:   but does not override ‘KFilterDev::Private(const KFilterDev::Private&)’
> kdelibs/kdecore/compression/kfilterdev.cpp:30: warning:   or ‘operator=(const KFilterDev::Private&)’
> 
> kdelibs/kdecore/compression/kgzipfilter.h:33: warning: ‘class KGzipFilter’ has pointer data members
> kdelibs/kdecore/compression/kgzipfilter.h:33: warning:   but does not override ‘KGzipFilter(const KGzipFilter&)’
> kdelibs/kdecore/compression/kgzipfilter.h:33: warning:   or ‘operator=(const KGzipFilter&)’
> kdelibs/kdecore/compression/kgzipfilter.cpp: In constructor ‘KGzipFilter::Private::Private()’:
> kdelibs/kdecore/compression/kgzipfilter.cpp:41: warning: ‘KGzipFilter::Private::zStream’ should be initialized in the member initialization list
> kdelibs/kdecore/compression/kgzipfilter.h:33: warning: ‘class KGzipFilter’ has pointer data members
> kdelibs/kdecore/compression/kgzipfilter.h:33: warning:   but does not override ‘KGzipFilter(const KGzipFilter&)’
> kdelibs/kdecore/compression/kgzipfilter.h:33: warning:   or ‘operator=(const KGzipFilter&)’
> kdelibs/kdecore/compression/kgzipfilter.cpp: In constructor ‘KGzipFilter::Private::Private()’:
> kdelibs/kdecore/compression/kgzipfilter.cpp:41: warning: ‘KGzipFilter::Private::zStream’ should be initialized in the member initialization list
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/compression/kfilterdev.cpp 1011431 
>   /trunk/KDE/kdelibs/kdecore/compression/kgzipfilter.cpp 1011431 
> 
> Diff: http://reviewboard.kde.org/r/1327/diff
> 
> 
> Testing
> -------
> 
> Compiles with less warnings and konqueror works with gzipped http content.
> 
> 
> Thanks,
> 
> Jaime
> 
>