Review Request: Fix sanitization of dbus path in KMainWindow (take 2)

Matthew Woehlke mw_triad at users.sourceforge.net
Tue Aug 18 17:34:18 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1353/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

As pointed out by Thomas L├╝bking ( http://permalink.gmane.org/gmane.comp.kde.devel.general/58749 ), KMainWindow attempts to sanitize what it will allow in the dbus path. This fixes it to only allow legal characters in the entire path (including the part from appName). Using QChar::isLetter and related allows non-ASCII, so we need our own validation function (this one in fact comes from qdbusutil.cpp).


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/widgets/kmainwindow.cpp 1012705 

Diff: http://reviewboard.kde.org/r/1353/diff


Testing
-------

built, ran kcalc


Thanks,

Matthew





More information about the kde-core-devel mailing list