Review Request: Fix sanitization of dbus path in KMainWindow

Matthew Woehlke mw_triad at users.sourceforge.net
Tue Aug 18 17:19:16 BST 2009


Thomas L├╝bking wrote:
> Am Tuesday 18 August 2009 schrieb Thiago Macieira:
>> I've also moved the application name above the cleanup, since it needs to
>> be cleaned up too. That required checking for /.
> 
> Unfortunately the appName() handling may however lead to more trouble here:
> http://permalink.gmane.org/gmane.comp.kde.devel.general/58753
> 
> Basically you'll have to choose out of a friction between appName and the dbus 
> path (thus an inconsistency), an artificially limited appName (no more 
> "plasma-desktop") or a full break in the KMainWindow dbus path (not invoke the 
> appName at all) 

"plasma-desktop" is already invalid (as I found out). If this is 
actually the appName it should be tripping the dbus name check assert... 
if KMainWindow is in use.

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
Cannot read .sig now





More information about the kde-core-devel mailing list