Review Request: Fix sanitization of dbus path in KMainWindow

[Thiago Macieira]

Em Terça-feira 18 Agosto 2009, às 15:34:12, você escreveu:
> Am Tuesday 18 August 2009 schrieb Thiago Macieira:
> > It means you just misused QString.
> 
> Indeed - forcing QString::fromUtf8("ß") makes it work as expected.
> Good to know =D
> (The Qt docu states that QString(const *char) makes implicit use of
> QString::fromAscii())
> 
> > Please compile your code with #define QT_NO_CAST_FROM_ASCII and
> > QT_NO_CAST_TO_ASCII.
> 
> this would be more like a call to whoever set an objectName/appName using
> utf-8 (and is pretty nasty in it's effect, btw ;-)
> 
> Another thing:
> the '_' substitution may be ambigious as e.g. "_sen" and "_sen" are the
>  very same strings...
> i'd suggest to insert _<unicode>_ instead, so "_214_sen" and "_228_sen"
>  remain individual (unless not used othwerwise... it's a far corner case
>  anyway)

Unnecessary. I doubt we'll have such objects.

They are often identifier names already.

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14     San Francisco, California: Nov 2 - 4
      http://qt.nokia.com/qtdevdays2009
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090818/3a88dad5/attachment.sig>