Review Request: Fix sanitization of dbus path in KMainWindow

Matthew Woehlke mw_triad at users.sourceforge.net
Mon Aug 17 22:26:55 BST 2009


Thomas Lübking wrote:
> Performance ain't crucial here (and QChar::isLetter() just tests some flags), 
> but i just tested and QChar grants ::isLetter to really a lot of stuff (esp. 
> as any utf-8 char seems to be split an the first part becomes a letter, though 
> it's /no/ [A-Za-z] :-(

Ah... doesn't that make QString::mid broken? (Or would that be QChar?) 
Though that shouldn't be a problem if e.g. "駄" gets translated to "G_q_".

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
Some people are like Slinkies... not really good for anything, but they 
still bring a smile to your face when you push them down a flight of 
stairs. -- Gordon Wolfe





More information about the kde-core-devel mailing list