Review Request: Fix sanitization of dbus path in KMainWindow

Thiago Macieira thiago at kde.org
Mon Aug 17 20:18:15 BST 2009


Matthew Woehlke wrote:
>Thomas L├╝bking wrote:
>> [other stuff and a Ship It]
>
>Thanks.
>
>> b) if QChar::isLetter() wouldn't rank "_" as letter it would be
>> replace by "_" anyway
>
>As far as I know, '_' isn't isLetter()... which I have ignored for this
>exact reason; yes, it is replaced, but it is replaced with itself :-).

There's a very specific list of characters that's allowed. Why not use 
that, instead of using the full unicode tables that QChar consults?

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

Qt Developer Days 2009 | Registration Now Open!
Munich, Germany: Oct 12 - 14     San Francisco, California: Nov 2 - 4
      http://qt.nokia.com/qtdevdays2009
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090817/50bf0692/attachment.sig>


More information about the kde-core-devel mailing list