Review Request: Fix description handling in Places entry editor
Christoph Feck
christoph at maxiom.de
Thu Aug 13 00:10:37 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1312/
-----------------------------------------------------------
(Updated 2009-08-12 23:10:37.625693)
Review request for Dolphin and kdelibs.
Changes
-------
Modified the default URL for "Add Entry..." to be the current URL, instead if "Home".
Summary
-------
This fixes a few problems with the "Description" of file places:
* it says "Description", but you are not going to enter a description, but only a (descriptive) label
* the "Enter description here" is not a clickMessage, but the actual default text
* due to setting this, automatic derivation of label from URL does not work as intended
* label derivation from URL fails for URLs without path or host (e.g. "ftp://ftp.test.org/", "music://")
Please also review string changes.
This addresses bug 159971.
https://bugs.kde.org/show_bug.cgi?id=159971
Diffs (updated)
-----
/trunk/KDE/kdelibs/kfile/kfileplaceeditdialog.cpp 1010310
/trunk/KDE/kdelibs/kfile/kfileplacesview.cpp 1010310
Diff: http://reviewboard.kde.org/r/1312/diff
Testing
-------
Thanks,
Christoph
More information about the kde-core-devel
mailing list