Review Request: Fix sanitization of dbus path in KMainWindow

Matthew Woehlke mw_triad at users.sourceforge.net
Mon Aug 10 23:27:09 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1261/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

As pointed out by Thomas L├╝bking ( http://permalink.gmane.org/gmane.comp.kde.devel.general/58749 ), KMainWindow attempts to sanitize what it will allow in the dbus path. However as written it would allow the illegal characters "." and "-" to be passed through.


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/widgets/kmainwindow.cpp 1009802 

Diff: http://reviewboard.kde.org/r/1261/diff


Testing
-------

built kdelibs and ran a KDE application


Thanks,

Matthew





More information about the kde-core-devel mailing list