Review Request: Add button to allow changing iconText() in KEditToolBar

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1243/#review1954
-----------------------------------------------------------


At first I was a bit suspicious of this change. Do we really *need* this functionality? It seems like overkill.

But the more I think about it, the more sense it makes. We have this wonderfully powerful platform with XMLGUI and sometimes I don't think we flaunt it enough. We already allow the user to change the icon and the shortcut of an action, so why not let them change the label too. It adds only a single button to a dialog most "basic" users will never see. The benefit isn't huge, but the cost is almost zero.

Of course, I hope you realise this opens the doors to all kinds of funny/nasty pranks. Switching the icons and labels of certain toolbar actions could make things quite interesting...

- Parker


On 2009-08-09 17:39:25, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1243/
> -----------------------------------------------------------
> 
> (Updated 2009-08-09 17:39:25)
> 
> 
> Review request for kdelibs and usability.
> 
> 
> Summary
> -------
> 
> This patch adds a "Change Text..." button to the tool bar edit dialog. This helps users who add many tool buttons to their tool bars, even those that have a quite long text. For example, the user could change "View Document Source" to just "Source".
> 
> The code respects any iconText() set by the application, and stores the changes together with the changed icon in the user's ui.rc file of the respective application.
> 
> It is intended that the changed text only shows in the right (active) action list, as it does not affect the menu texts.
> 
> Maybe we should have a button to revert to default text (and icon) for individual actions, I may add that separately.
> 
> 
> This addresses bug 201346.
>     https://bugs.kde.org/show_bug.cgi?id=201346
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/dialogs/kedittoolbar.cpp 1009073 
>   /trunk/KDE/kdelibs/kdeui/dialogs/kedittoolbar_p.h 1009073 
> 
> Diff: http://reviewboard.kde.org/r/1243/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> KEditToolBar dialog with added "Change Text..." button
>   http://reviewboard.kde.org/r/1243/s/167/
> 
> 
> Thanks,
> 
> Christoph
> 
>