Review Request: Add button to allow changing iconText() in KEditToolBar
Christoph Feck
christoph at maxiom.de
Sun Aug 9 18:39:25 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1243/
-----------------------------------------------------------
(Updated 2009-08-09 17:39:25.008942)
Review request for kdelibs and usability.
Changes
-------
Added a screen shot. Demonstrated here is changing the "Home Page" text to just "Home". As you can see, the original text or description is displayed below the lists, in case the user cannot remember the meaning of his abbreviation.
Summary
-------
This patch adds a "Change Text..." button to the tool bar edit dialog. This helps users who add many tool buttons to their tool bars, even those that have a quite long text. For example, the user could change "View Document Source" to just "Source".
The code respects any iconText() set by the application, and stores the changes together with the changed icon in the user's ui.rc file of the respective application.
It is intended that the changed text only shows in the right (active) action list, as it does not affect the menu texts.
Maybe we should have a button to revert to default text (and icon) for individual actions, I may add that separately.
This addresses bug 201346.
https://bugs.kde.org/show_bug.cgi?id=201346
Diffs
-----
/trunk/KDE/kdelibs/kdeui/dialogs/kedittoolbar.cpp 1009073
/trunk/KDE/kdelibs/kdeui/dialogs/kedittoolbar_p.h 1009073
Diff: http://reviewboard.kde.org/r/1243/diff
Testing
-------
Screenshots
-----------
KEditToolBar dialog with added "Change Text..." button
http://reviewboard.kde.org/r/1243/s/167/
Thanks,
Christoph
More information about the kde-core-devel
mailing list