Review Request: Constifying two methods in KCoreConfigSkeleton

Parker Coates parker.coates at
Thu Aug 6 16:03:37 BST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-08-06 15:03:37.221201)

Review request for kdelibs.


Added @since 4.4 tags.


KCoreConfigSkeleton::isImmuttable and KCoreConfigSkeleton::findItem are non-const methods, even though neither of them touch the internal state of the object. This patch adds const overloads for those two methods.

For binary compatibility reasons, the existing methods can't be removed. I've added "KDE5 TODO" comments indicating that the non-const versions should be removed in the future. Should they also be marked depreciated? That would seem a bit silly as the compiler automatically selects which of the two versions to call. Should I add a note to the API documentation, or is that really necessary? Is the use of const_cast in the non const versions a safe way to keep only a single implementation? Is there anything else I'm missing?

Diffs (updated)

  trunk/KDE/kdelibs/kdecore/config/kcoreconfigskeleton.h 1007370 
  trunk/KDE/kdelibs/kdecore/config/kcoreconfigskeleton.cpp 1007370 





More information about the kde-core-devel mailing list