Review Request: Copy location in dolphin should return regular path and not file://

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1192/#review1877
-----------------------------------------------------------

Ship it!


Thank you for the patch! Please commit version #2 (if you don't have a SVN account, please let me know and I'll commit it for you).

- Peter


On 2009-08-01 14:05:31, Shane Gibbs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1192/
> -----------------------------------------------------------
> 
> (Updated 2009-08-01 14:05:31)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Summary
> -------
> 
> Hi all, this is my first attempt at a bug. I'm still getting my head around the KDE libraries so any feedback would be great. This is based on https://bugs.kde.org/show_bug.cgi?id=170608 which is for dolphin however the patch is for kfile in kdelibs.
> 
> The patch alters KUrlButton so that when you copy a local file:// url it gives you the absolute path.
> 
> E.g. Copies:
>     /home/kde-devel/kde
> instead of
>     file:///home/kde-devel
> 
> This makes the path usable outside KDE apps.
> 
> I am assuming that if you have a KUrl with the protocol set to "file", then url() will always return the path QString starting with file://
> 
> Thanks
> Shane
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kfile/kurlbutton.cpp 1005432 
> 
> Diff: http://reviewboard.kde.org/r/1192/diff
> 
> 
> Testing
> -------
> 
> Copied local urls and some sftp remote urls to confirm expected behavior.
> 
> 
> Thanks,
> 
> Shane
> 
>