Review Request: 'Recent Places' per application and context

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/643/#review1004
-----------------------------------------------------------


I did not look at the code yet, but from my personal point of view I'd remove the "Recent Places" entry from the toolbar, the entry in the places sidebar is sufficient.

This feature might be in conflict with the nepomuk-IO-slave. If you just enter nepomuk:// as URL, you get a recent places directory for free. Maybe it would be enough to add a "nepomuk://"-entry to the places sidebar?

- Peter


On 2009-04-29 13:49:22, Luca Bellonda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/643/
> -----------------------------------------------------------
> 
> (Updated 2009-04-29 13:49:22)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> 
> One of Plasma goals is to have applications that adapt to the user working context.
> 
> This is a patch (against revision 953905) to have a 'Recent Places' in Open File dialog that can be linked to Plasma activities and Nepomuk (in future, not now) to have different working environments for the same applications when used in different contexts.
> 
> In the actual version it is a working prototype to test the idea. It has only one default activity and stores data as file. No modifications to existing KDE applications are needed, only a recompile.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdecore/CMakeLists.txt 953905 
>   trunk/KDE/kdelibs/kdecore/services/kuserenvironment.h PRE-CREATION 
>   trunk/KDE/kdelibs/kdecore/services/kuserenvironment.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/kfile/CMakeLists.txt 953905 
>   trunk/KDE/kdelibs/kfile/kdiroperator.h 953905 
>   trunk/KDE/kdelibs/kfile/kdiroperator.cpp 953905 
>   trunk/KDE/kdelibs/kfile/kdiroperatorextendedview.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/kfile/kdiroperatorextendedview_p.h PRE-CREATION 
>   trunk/KDE/kdelibs/kfile/kfilemodule.h 953905 
>   trunk/KDE/kdelibs/kfile/kfilemodule.cpp 953905 
>   trunk/KDE/kdelibs/kfile/kfileplacesmodel.cpp 953905 
>   trunk/KDE/kdelibs/kfile/kfilewidget.h 953905 
>   trunk/KDE/kdelibs/kfile/kfilewidget.cpp 953905 
>   trunk/KDE/kdelibs/kfile/krecentplacesdelegate.h PRE-CREATION 
>   trunk/KDE/kdelibs/kfile/krecentplacesdelegate.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/kfile/krecentplacesmodel.h PRE-CREATION 
>   trunk/KDE/kdelibs/kfile/krecentplacesmodel.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/kio/kfile/kabstractfilemodule.h 953905 
>   trunk/KDE/kdelibs/kio/kfile/kfile.h 953905 
>   trunk/KDE/kdelibs/kio/kfile/kfile.cpp 953905 
>   trunk/KDE/kdelibs/kio/kfile/kfiledialog.cpp 953905 
>   trunk/KDE/kdelibs/kio/kfile/krecentdirs.h 953905 
>   trunk/KDE/kdelibs/kio/kfile/krecentdirs.cpp 953905 
> 
> Diff: http://reviewboard.kde.org/r/643/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> preview
>   http://reviewboard.kde.org/r/643/s/109/
> 
> 
> Thanks,
> 
> Luca
> 
>