KModifierKeyInfo moved to kdereview

[Michael Leupold]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Christoph Feck wrote:
> Am Monday 27 April 2009 10:12:56 schrieb Michael Leupold:
>> I just moved KModifierKeyInfo to kdereview. This class provides a
>> high-level interface to modifier key state detection
> 
> Hm, shouldn't the "synchronous" methods be static and not install any xkb
> handler? Nice idea otherwise, the password dialog really needs an CapsLock
> indication, I think there is even a bug report about that.

The class is generally meant for client code that wants to get updates about 
the state of the modifiers and that uses isPressed/Latched/Locked to get the 
initial state. I can't think of a use-case where someone would just need the 
synchronous methods - at least nothing that would justify additional 
complexity.

If isPressed/... should be static then either KModifierKeyInfoProvider would 
have to be a singleton (complexity for reference counting or similar) or the 
class would have to ask X for every request (figure out the modifier mask 
and query it).

Regards,
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFJ9Z/blfpzINIAlVsRAjybAJ91GbWIKv0BLDryGi/39g2IebSbIACgmEWN
/LK+BnKL+tOTUCscsnjDVEA=
=+BdA
-----END PGP SIGNATURE-----