Review Request: Fix KTimeZoneWidget to work well with KTreeWidgetSearchLine
Aaron Seigo
aseigo at kde.org
Mon Apr 27 09:59:56 BST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/616/#review996
-----------------------------------------------------------
Ship it!
/trunk/KDE/kdelibs/kdeui/widgets/ktimezonewidget.cpp
<http://reviewboard.kde.org/r/616/#comment678>
please follow the kdelibs coding style: even single line blocks need {}s
- Aaron
On None, Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/616/
> -----------------------------------------------------------
>
> Review request for kdelibs.
>
>
> Summary
> -------
>
> KTimeZoneWidget uses QTreeWidget::selectedItems() to get a list of selected time zones. This does not work well when used with a KTreeWidgetSearchLine
> because selectedItems() skips hidden items. Attached diff use a QTreeWidgetItemIterator instead.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/kdeui/widgets/ktimezonewidget.cpp 956554
>
> Diff: http://reviewboard.kde.org/r/616/diff
>
>
> Testing
> -------
>
> Tested with upcoming patch for Plasma clock timezone configuration.
>
>
> Thanks,
>
> Aurélien
>
>
More information about the kde-core-devel
mailing list