protected slots from KConfigDialog removed

Thiago Macieira thiago at kde.org
Tue Apr 14 21:35:16 BST 2009


Aaron J. Seigo wrote:
>On Tuesday 14 April 2009, Frederik Gladhorn wrote:
>> In revision 721220 KConfigDialog was changed.
>>
>> Two slots that allowed KConfigDialog subclasses with widgets not
>> managed by KConfigDialog to update the dialog/button state.
>> This is no longer possible and makes it for example impossible to
>> update the Apply button in the desktop config dialog (right click on
>> desktop). I'd like to add at least updateButtons() again.
>>
>> protected Q_SLOTS:
>>      void updateButtons();
>>      void settingsChangedSlot();
>
>that entire commit needs to be reverted because it's not binary
> compatible. you can only remove private methods, not protected ones!

The change happened in October 2007, before the KDE 4.0 release.

The only thing we can blame Tobias for is for doing it on a Thursday, not 
on a Monday :-)

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090414/04b8c1bf/attachment.sig>


More information about the kde-core-devel mailing list