Review Request: Add async requests to kpasswdserver

Michael Leupold lemma at
Tue Apr 14 12:40:59 BST 2009

This is an automatically generated e-mail. To reply, visit:

(Updated 2009-04-14 04:40:59.186295)

Review request for kdelibs.


This new patch reworks parts of what I previously did:
* use a qdbusxml2cpp-generated adaptor
* no more defines/static const needed
* overload addAuthInfo using the new dbusargumentified KIO::AuthInfo as well
* using qDeleteAll (silly me :))

I'd say it's slicker overall.

Additional note:
Currently creates the adaptor on building. The D-Bus xml file is included and it's currently redundant (other version in kdelibs/kio/kio). Starting from 4.3 we could remove the one in kdebase/runtime/kpasswdserver and use the one installed by kdelibs/kio/kio. Of course we could also strip the adaptor-generation and add a static kpasswdserveradaptor.


This patch adds async requests to kpasswdserver. It adds checkAuthInfoAsync and queryAuthInfoAsync as well as appropriate signals to return the results back to the client.

The goal is to not have requests sent from kioslaves time-out in the future.

This patch depends on a patch to kdelibs which I'll post in a minute.

Diffs (updated)

  /trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.cpp 948864 
  /dev/null 948864 
  /trunk/KDE/kdebase/runtime/kpasswdserver/CMakeLists.txt 948864 
  /trunk/KDE/kdebase/runtime/kpasswdserver/kpasswdserver.h 948864 





More information about the kde-core-devel mailing list