[PATCH] Take care also of the KJob::finished signal in KPart - it also fixes Ark's BUG 187538
faure at kde.org
Tue Apr 7 21:34:14 BST 2009
On Tuesday 07 April 2009, David Faure wrote:
> I hadn't realized that the default for kill() had changed in kde4.
It was changed, but in fact the other job trackers do call kill(EmitResult):
./kabstractwidgetjobtracker.cpp:80: job->kill(KJob::EmitResult); // notify that the job has been killed
./kstatusbarjobtracker.cpp:143: job->kill(KJob::EmitResult); // notify that the job has been killed
which proves that the expected behavior hasn't really changed :)
The bug is only in kuiserverjobtracker.cpp which calls kill() without an EmitResult
because of a direct signal/slot connection. I'm very much in favour of rakuco's patch
(with better handling of the race where the jobview isn't in the map anymore,
we're talking about it on irc now).
David Faure, faure at kde.org, sponsored by Qt Software @ Nokia to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
More information about the kde-core-devel