[PATCH] Take care also of the KJob::finished signal in KPart - it also fixes Ark's BUG 187538

Kevin Ottens ervin at kde.org
Tue Apr 7 08:26:38 BST 2009

On Tuesday 7 April 2009 04:10:17 Raphael Kubo da Costa wrote:
> 2009/4/6 Kevin Ottens <ervin at kde.org>:
> > And again, looking at the patch it seems that the problem is simply
> > resetting the m_job pointer to 0 when the job deletes itself. There's a
> > proper tool for that and it is called QPointer. So why not simply using
> > that?
> I'm still not fully convinced. Using a QPointer does prevent
> ReadOnlyPart from crashing indeed, but _k_slotJobFinished (which not
> only sets m_job to 0 but also emits some signals and checks for
> errors) still isn't being called when the job is cancelled. Is it
> really the desired behaviour?

Well, I can't comment on what's really desired inside ReadOnlyPart. David 
probably can.

Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090407/ff1e1e6e/attachment.sig>

More information about the kde-core-devel mailing list