[PATCH] Take care also of the KJob::finished signal in KPart - it also fixes Ark's BUG 187538
Raphael Kubo da Costa
kubito at gmail.com
Mon Apr 6 15:12:11 BST 2009
2009/4/6 Alessandro Diaferia <alediaferia at gmail.com>:
> 2009/4/6 Alessandro Diaferia <alediaferia at gmail.com>
>> A one line-patch that fixes a crash for Ark: when the user stops the job
Actually, it fixes some other bug reports related to this too -- see
the bugs listed in the reviewboard entry.
>> via the notification handler the m_job var should be set to 0 in order to
>> avoid future crashes when exiting the application. This doesn't get done
>> until the finished signal is connected to the proper slot.
>> Hope this is useful.
> Really sorry for duplicating Raphael's mail, forget me if my patch isn't ok.
The patch looks fine and indeed solves the problem I pointed out in
reviewboard. Can someone else OK it?
As a sidenote, from the documentation (api.kde.org) for KJob it wasn't
clear that the finished signal would be emitted in cases the result
signal would not. Both say "Emitted when the job is finished, in any
case". Should it be updated?
More information about the kde-core-devel