Review Request: Strip duplicated path separators in KUrlNavigator

Ingo Klöcker kloecker at kde.org
Wed Apr 1 19:15:18 BST 2009


Hi Raphael,

On Wednesday 01 April 2009, Raphael Kubo da Costa wrote:
> I'm manually sending this email do k-c-d as it was not sent and is
> not in the moderation list either.

I have received your review request via k-c-d. Did you probably enable 
the option to not receive messages from k-c-d if your address is also 
listed explicitly in the To/CC header?


Regards,
Ingo


> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/470/
> -----------------------------------------------------------
>
> Review request for Dolphin and kdelibs.
>
>
> Summary
> -------
>
> This fixes bug 188417: when passing a path with duplicated separators
> (such as "/tmp//foo" or "/tmp//foo//bar") to KUrlNavigator, the
> breadcrumb is not displayed correctly (it only shows directories
> prior to the first duplicated separator -- in this case, '/' and
> 'tmp').
>
> I just don't know if there are problems regarding creating a
> non-const KUrl url from const KUrl& newUrl in KUrlNavigator::setUrl.
>
>
> This addresses bug 188417.
>    https://bugs.kde.org/show_bug.cgi?id=188417
>
>
> Diffs
> -----
>
>  /trunk/KDE/kdelibs/kfile/kurlnavigator.cpp 945690
>
> Diff: http://reviewboard.kde.org/r/470/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raphael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20090401/9a7bf5b5/attachment.sig>


More information about the kde-core-devel mailing list