Suspicious code in kdelibs/kdebase revision 864329

[Germain Garand]

Le mercredi 24 septembre 2008, Christoph Bartoschek a écrit :
> - kdelibs/khtml/khtmlview.cpp:2933
>
> I guess this break wants to be behind the following line. See line 2915.
>
> - kdelibs/khtml/xml/dom_nodeimpl.cpp:332
>
> r is used here but never got a value. Same ofr the other values.
>
> - kdelibs/khtml/xml/xml_tokenizer.cpp:505
>
> Line 502 indicates that body can be NULL here. A crash follows.
>
> - kdelibs/khtml/xml/dom_xmlimpl.cpp:483
>
> Line 481 indicates that m_sheet can be NULL here. A crash follows.
>
> - kdelibs/khtml/xml/dom_selection.cpp:827
>
> Line 824 indicates that renderNode can be NULL here. A crash follows.
>
> - kdelibs/khtml/html/html_baseimpl.cpp:735
>   kdelibs/khtml/html/html_imageimpl.cpp:160
[..]
>
> A break might be missing. A fall through comment would be nice.
>
> - kdelibs/khtml/editing/jsediting.cpp:581
>
> If command == sizeof commands / sizeof commands[0] then line 583 is an
> access out of bounds.

all of those fixed as of r865829 by Harri and me.

>   kdelibs/khtml/rendering/bidi.cpp:1103,1154

is pending.

Thank you,
Germain