qt-copy broken

[Andreas Pakulat]

On 24.09.08 10:56:09, Christian Ehrlicher wrote:
> > Von: Andreas Pakula
> > On 23.09.08 23:12:49, Michael Pyne wrote:
> > > On Monday 22 September 2008, Andreas Pakulat wrote:
> > > > On 23.09.08 00:14:05, Alex Merry wrote:
> > > > > On Monday 22 September 2008 23:55:18 Michael Pyne wrote:
> > > > > > I'll look at it but I think the change in question is that
> > kdesvn-build
> > > > > > no longer copies anything over for qt-copy.  i.e. it assumes that
> > the
> > > > > > configure script can be run in a different build directory than
> > the
> > > > > > source directory like with automake and cmake.
> > > > >
> > > > > Up to about 3 or 4 weeks ago, I built qt-copy in a separate
> > directory
> > > > > (ie: ../../src/qt-copy/configure -prefix $PWD -other-options &&
> > make),
> > > > > and this always worked fine for me.  So I can't see why it should
> > > > > suddenly stop working now, if this is what kdesvn-build does.
> > > >
> > > > Two notes:
> > > >
> > > > a) its been broken very recently, i.e. after the switch to 4.4.2
> > > > probably
> > > > b) I'm using -prefix != $PWD, i.e. a real installation
> > > 
> > > I've rebuilt it with kdesvn-build today and QtGlobal was not installed. 
> > > However kdesvn-build shouldn't do anything that should cause this so I'm
> > > rebuilding manually to see if there's a difference.  It's not done yet
> > but I'm 
> > > going to sleep, I'll write back tomorrow with the results.
> > 
> > Its Patch 0250 thats causing the problem. Its supposed to be used on
> > win32 only, but apparently has some side-effects. Christian Ehrlicher is
> > aware of it, but I guess he wouldn't mind some help from a Perl expert
> > :)
> > 
> Yes - I really don't understand why this patch should break linux compile... 

But I do understand it now. The problem is that checkUnix has side-effects.
Yes Perl is really a nasty language :P (sometimes). It changes the value of
$_ which happens to be pointing into the @classes array and hence the
change from QtConCurrentRun to "linux" on my machine.

Christian unless I'm mistaken the matching can only work on win32 anyway,
because its now bound to <letter>: only, i.e. only stuff like c:, d: and so
on match. So I think I can just remove the checkUnix() and be done with it.

Other thoughts?

Andreas

-- 
Snow Day -- stay home.