Suspicious code in revision 864329

[Aaron J. Seigo]

On Wednesday 24 September 2008, Christoph Bartoschek wrote:
> - kdebase/workspace/plasma/containments/panel/panel.cpp:319
>   kdebase/workspace/plasma/containments/mid-panel/panel.cpp:261
>
> This if statement is always true because the compiler reads
> (form == Plasma::Horizontal) || Plasma::Vertical and
> Plasma::Vertical is not 0.
>
> - kdebase/workspace/plasma/shells/desktop/panelview.cpp:82
>
> Line 74 indicates that panel could be NULL here.
>
> - kdebase/apps/konqueror/src/konqview.cpp:196
>
> Line 175 indicates that m_pPart could be NULL here. Same for lines 150 and
> 168.

all the above are now fixed.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080924/47efed99/attachment.sig>