kxmlgui shortcuts regression

[Robert Knight]

> I think we have to wait for Davids opinion on that matter. But if iirc i have
> seen Robert Knight fighting in konsole with something that looks like what you
> report. Am i right robert?

The problem in Konsole was deciding whether to send shortcuts to the
host (eg. Kate) or
to the terminal when they were pressed while the terminal had focus -
because a shortcut like Ctrl+C for example is used in both.
Right now the behavior we use is to send single modifier shortcuts to
the terminal by default and give the host a way
to override them by responding to a signal from the part.

Regards,
Robert.

2008/9/22 David Faure <faure at kde.org>:
> On Sunday 21 September 2008, Michael Jansen wrote:
>> > > Could you please give a use case? I have no idea what you are talking
>> > > about. But perhaps david can help you as in "know that beast
>> > > kxmlguiclient".
>> >
>> > Lets take KDevelop (though in theory even konqueror with multiple tabs
>> > should do):
>> >
>> > - open two file, you get two tabs. Lets say fileA and fileB
>> > - Focus fileA and open shortcuts editor
>> > - change a shortcut thats specific for the xmlgui-client - i.e. not part
>> >   of the application. In my example I'm changing "Capitalize" which is
>> >   a katepart shortcut, to Meta+Ctrl+C
>> > - close the editor via "ok"
>> > - check wether the shortcut works, for me it does
>> > - Switch to fileB by clicking on the tab or using Alt+Left/Right,
>> >   doesn't matter
>> > - try the shortcut, it doesn't work. Go to the shortcuts editor and see
>> >   that the shortcut for the action is back to Default, i.e. Ctrl+Alt+U
>> >   in the case of Capitalize
>
> Right.
> But how is this a "regression"?
> Did this really work in KDE3? I have very strong doubts about that.
>
>> > Now I'm not sure where the error is in this case, wether its the xmlgui
>> > framework not notifying its clients about changes in the shortcuts, or
>> > the clients not doing the right thing or wether the app is responsible
>> > for notifying the clients. But somethings wrong for sure.
>
> Yes, something's missing.
> To take the matter further, what if you had katepart embedded into
> two different applications, at the same time, and changed shortcuts in
> one of them? To make both use cases work, I think what we need is
> DBUS notification. But at the same time, I am not sure we want to
> register each and every kxmlguiclient to dbus...
> Another solution would be to use KDirWatch on the file where
> the shortcuts are saved (that's a local xmlgui file, not kconfig, right?)
> The third solution is "you must restart your application for these changes
> to take effect" ;-)
>
> --
> David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
> Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
>