External SVN item in kdebase/runtime/nepomuk/services/queryservice/lib

Matthew Woehlke mw_triad at users.sourceforge.net
Thu Sep 18 21:27:36 BST 2008


Thiago Macieira wrote:
> Matthew Woehlke wrote:
>> Andreas Pakulat wrote:
>>> How do you suggest to solve the following:
>> In addition, what about:
>>
>> - code shared between two libraries that itself is not appropriate for a
>> library (because it should not be publically accessible), where it is
>> important for the copies to stay 100% in sync.
> 
> Use a private header and export the symbols.
> 
> Qt does a lot of that. The private headers are still available during the 
> build. And since they are in the same module, which is always built as a 
> whole, there's no problem breaking binary- or source-compatibility.

They're *not* in the same module.

> Git supports symlinks.

Sure, but...

> If we ditch building on filesystems where symlinks 
> aren't supported (read: Windows), we can use them.

...I don't see this happening. Besides, symlinks require your source 
tree to look a certain way, and I don't see that going over well, either.

> And I also do not agree that it's the preferred solution. A library is the 
> preferred solution, since that reduces code duplication when loaded into 
> memory.

We've had this conversation before. Having to put private code in an 
installed library (with installed headers) is not liked.

If we switch to git, maybe we'll have to, but I still consider it a 
notably non-optimal solution. It would be better if git supported 
server-side externals (like svn is supposed to, either in 1.5 or "Real 
Soon Now").

-- 
Matthew
ENOCOFFEE: operator suffering from lack of sleep and/or early-morning-itis





More information about the kde-core-devel mailing list