Strange KFileDialog ctor
John Tapsell
johnflux at gmail.com
Thu Sep 18 18:24:40 BST 2008
If KFileDialog just splits the string, it would be better to replace
the ctor with your version. Although I guess it's too late for for
backwards compatibility.
2008/9/18 Christian Ehrlicher <Ch.Ehrlicher at gmx.de>:
> Hi,
>
> the KFileDialog currently wants a QString as filter. This leads to
> constructs like this:
>
> QString filter = mimeTypes.join (" ");
> KFileDialog fd (startURL, filter, this);
>
> inside the ctor setFilter() is used which then has to determine that it's a
> joined-mimetype string and has to split it up.
>
> Therefore I suggest a new ctor:
>
> KFileDialog( const KUrl& startDir, const QStringList& mimefilter,
> QWidget *parent, QWidget* widget = 0 );
>
> to avoid the useless join/split
>
>
> Comments?
> Christian
>
More information about the kde-core-devel
mailing list