External SVN item in kdebase/runtime/nepomuk/services/queryservice/lib

[Aaron J. Seigo]

On Wednesday 17 September 2008, Thiago Macieira wrote:
> Can we please find a solution without svn:externals?
>
> This is duplicating code. Move it to a library.

it is a library, it's just in workspace when it should be in either kdelibs or 
runtime.

there's another similar issue in workspace/libs/nepomukqueryclient/interfaces 
which is duplicating dbus xml files

my suggestion on the commit list for that one was this:

* set a variable in workspace/CMakeLists.txt:

if(CMAKE_SOURCE_DIR STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
    set(WORKSPACE_STANDALONE 1)
endif(CMAKE_SOURCE_DIR STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")

* check for that variable in nepomukqueryclient/CMakeLists.txt and either 
reference the xml files directly in runtime if kdebase is built as a whole or 
reference the xml files in the installation directory if workspace is built as 
a separate library

can anyone see any downsides to that?

if not, i think i'll end up moving all this stuff around this week if Trueg 
doesn't get to it.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080917/ec2aad9b/attachment.sig>