Wrong usage of QList::ConstIterator & QList::begin() ?

Allen Winter winter at kde.org
Sat Oct 18 13:58:47 BST 2008


On Saturday 18 October 2008 8:25:44 am Christian Ehrlicher wrote:
> Allen Winter schrieb:
> > On Saturday 18 October 2008 5:45:06 am Christian Ehrlicher wrote:
> >> Therefore I suggest to add QT_STRICT_ITERATORS to the kdelibs flags. Or 
> >> does this maybe break BC?
> >>
> > 
> > Christian,
> > 
> > Would you try and see how much compile breakage you find?
> > I guess add -DQT_STRICT_ITERATORS to the CMAKE_CXX_FLAGS_DEBUGFULL
> > in kdelibs/cmake/modules/FindKDE4Internal.cmake
> > 
> > Let's experiment with debugfull.  Seems like a good idea to me.
> > 
> My idea was to add this flag locally for kdelibs, fix all places and 
> then add the flag with add_definitions() to CMakeLists.txt in kdelibs root.
> This would ensure that I don't break anything outside kdelibs and that 
> no new code in kdelibs will contain the wrong usage :)
> 
True. That should work.
Sounds like a good idea for kdepimlibs too.

But only for debug builds.





More information about the kde-core-devel mailing list