[PATCH] KDialog::groupSpacingHint()

Parker Coates parker.coates at gmail.com
Mon Oct 6 14:36:50 BST 2008

On Mon, Oct 6, 2008 at 03:17, Luciano Montanaro  wrote:
> Having a method to get the spacing is good, since it is something that
> should not be hardcoded
> (think higher resolution displays or small devices). But wouldn't it
> be better to be a property of the style?
> In this way it would be possible to use smaller spaces on small
> screen/small resolution displays, with a customized style.
> Other than that, why is this size specified in pixels? I think the
> font size should be involved in its calculation.
> Can it be expressed in function of the x height of the "normal" font,
> or the linespacing of the "normal" font?

Those suggestions are all well and good, but they're also way out of
my league. I'm just a selfish app developer proposing to add this
method so that I can call it in my own code. I don't care where the
number comes from, as long as I don't have to hardcode it. ;)

Making all three of these methods theme and/or font size dependent
seems like a good idea to me, and if someone with the time and
know-how wanted to do so, that'd be great. But it seems unlikely to
happen before 4.2, so I'm proposing we use a constant 16 pixels for
the moment, so code can start using it. If a more advance solution
happens in the future, everyone will get the benefits automatically.


More information about the kde-core-devel mailing list