[PATCH] KDialog::groupSpacingHint()

Parker Coates parker.coates at gmail.com
Mon Oct 6 07:48:13 BST 2008


The latest KDE HIG offers using a vertical space of 16 pixels as an
additional method of grouping logically related items in a dialog. [1]
Rather than have this 16 pixel value hardcoded in dozens of different
dialogs, I propose adding a groupSpacingHint() method to the KDialog
class. [2] This is a static method that returns a constant in the same
vein as KDialog::marginHint() and KDialog::spacingHint().

The attached patch adds such a method. Any comments?


[1] http://techbase.kde.org/Projects/Usability/HIG/Form_Label_Alignment#Grouping_related_options_within_a_GroupBox

[2] I realise that KDialog isn't necessarily the most logical place
for these functions to live, but spacingHint() and marginHint() are
already there and placing groupSpacingHint() anywhere else would be
even less logical.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdialog.diff
Type: text/x-diff
Size: 2771 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081006/adce993e/attachment.diff>

More information about the kde-core-devel mailing list