Suspicious code in revision 867140 (Part 2)

[Aaron J. Seigo]

On Saturday 04 October 2008, Christoph Bartoschek wrote:
> kdebase/workspace/plasma/dataengines/nowplaying/playerinterface/mpris/mpris
>.cpp:344
>
> The expression is always false. !caps can be 0 or 1. CAN_PROVIDE_METADATA
> is (1 << 5)

fixed; a boolean operator error

> - kdebase/workspace/plasma/shells/desktop/panelview.cpp:82
>
> Line 74 indicates that panel can be NULL here.

fixed

> - kdebase/workspace/plasma/tools/engineexplorer/main.cpp:59, 66
>
> No need to use boolean arithmetic here.

fixed

> - kdebase/workspace/plasma/tools/engineexplorer/serviceviewer.cpp:101
>
> Line 89 indicates that m_operations can be NULL here.

oops, should've been if (m_service); fixed

> - kdebase/workspace/plasma/dataengines/network/networkengine.cpp:200
>
> Line 186 indicates that ap can be NULL here.

fixed.

thanks =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081005/4aaf6af3/attachment.sig>