Suspicious code in revision 867140 (Part 2)

[Andi Fischer]

Christoph Bartoschek wrote:
> - kdesdk/umbrello/umbrello/dialogs/parmpropdlg.cpp:135
>
> Line 119 indicates that attr can be NULL here.
>   
fixed
> - kdesdk/umbrello/umbrello/dialogs/umloperationdialog.cpp:469
>
> Line 448 indicates that classfier can be NULL here.
>   
fixed
> - kdesdk/umbrello/umbrello/codegenerators/textblock.cpp:192
>
> One should use pointers instead of a reference here. A function can always 
> rely 
> on the fact that references are not NULL. If this is not the case a pointer
> is the correct data type.
>   
fixed
> - kdesdk/umbrello/umbrello/codegenerators/tcl/tclwriter.cpp:603,310
>
> The QTextStream from line 315 is destructed here. However mStream still holds
> a pointer to it.
>   
not yet fixed
> - kdesdk/umbrello/umbrello/associationwidget.cpp:3301 
>
> A break is missing.
>   
not yet fixed
> - kdesdk/umbrello/umbrello/foreignkeyconstraint.cpp:146
>   kdesdk/umbrello/umbrello/uniqueconstraint.cpp:203,227
>
> Line 144 indicates that owningParent is NULL here.
>   
fixed
> - kdesdk/umbrello/umbrello/linepath.cpp:603
>
> Is a break missing in line 602?
>   
no, not fixed

Thanks,
Andi