[PATCH] Removing unnecessary friend declarations from kcolordialog.h

Christoph Bartoschek bartoschek at gmx.de
Sat Oct 4 19:13:34 BST 2008

Am Samstag 04 Oktober 2008 schrieb Albert Astals Cid:
> A Dissabte 04 Octubre 2008, Christoph Bartoschek va escriure:
> > Hi,
> >
> > the following patch removes three unnecessary friend declarations from
> > kcolordialog.h.
> >
> > This patch is necessary to compile KDE code with EDG-based compilers.
> > They choke on the second and third firend declaration, because they seem
> > to be obviously wrong.
> I can see the second and third are wrong because they are for classes that
> don't exist in that scope, but the first?

The first is not wrong. However it is unnecessary. First, this higher 
privileges are not used, as far as I can see it. Second, the revised C++ 
standard will give inner classes access to private members of the outer 
classes if I remember correctly.

Maybe it is not yet approved: 


More information about the kde-core-devel mailing list