[PATCH] Klipper port to KConfigXT - patch or a feature?

[Sebastian Kügler]

On Thursday 27 November 2008 19:59:17 Dmitry Suzdalev wrote:
> On Thursday 27 November 2008 21:41:04 Sebastian Kügler wrote:
> > Which bug will it fix, which ones might be candidates?
>
> Nothing major.
> One it definitely fixes is that Apply button of config dialog is now
> correctly enabled/disabled when editing actions in an Actions page.
> (https://bugs.kde.org/show_bug.cgi?id=164743)

I can reproduce this.

> Plus it can theoretically fix some URLGrabber-related crashes (because i
> slightly changed the way this object is created/destructed).
> I asked users for info to reproduce some of crashes on b.k.o (while closed
> some of them not reproducible even in trunk).
>
> So, I'd say on a bug side this is not fixes-a-major-bug(s) patch.

I'm tending towards "merge it", we're early enough in the cycle to warrant 
such a cleanup and improve current code thing, provided:

- the klipper maintainer wants it in (who's that?)
- no new string

It's not a strong preferene, and I probably lack a good enough overview of 
klipper to judge. Don't take this as a "sure, just commit". If you can 
convince people that it indeed fixes crashers, then chances to get an OK 
increase :)
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 489 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081127/1da559a1/attachment.sig>