[PATCH] thread-safe queued KDialogs

Thiago Macieira thiago at kde.org
Sat Nov 22 22:08:00 GMT 2008

Sebastian TrĂ¼g wrote:
>The attached patch makes queued dialogs thread-safe. With it, queued
>KMessagesBoxes and thus, the default KMessage messasge handler.
>This fixes a crash in KRunner when KMimeType tried to complain about
> missing mimetypes using KMessage which in turn uses KMessageBox which
> tries to open a QWidget from a thread which is not the GUI thread which
> triggers an assert. :)
>May I apply?

What's the number 20? Where did the 20 milliseconds timer come from? Why 
not 25?

I know it's not your code, but maybe someone else knows where this value 
came from. Let's not keep arbitrary things.

  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081122/cd4f6d91/attachment.sig>

More information about the kde-core-devel mailing list