kdereview exemption for PolicyKit-KDE

Thiago Macieira thiago at kde.org
Mon Nov 17 20:00:50 GMT 2008

On Monday 17 November 2008 20:45:48 Fredrik Höglund wrote:
> add_io_watch() is implemented using a QSocketNotifier, so that
> doesn't require a lot of code. To implement add_child_watch(), about
> 200 lines of code from qprocess_unix.cpp was copied into the agent
> and adapted for this purpose.

Overriding the SIGCHLD handler is a source of trouble.

In any case, do not remove the handler. Keep it there forever.

Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Software Engineer - Nokia, Qt Software
  Qt Software is hiring - ask me
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081117/3f4eb741/attachment.sig>

More information about the kde-core-devel mailing list