build of kdelibs trunk broken?

[Matthew Woehlke]

Andrew wrote:
> CMakeFiles/kjs.dir/scope_chain.o: In function 
> `KJS::ScopeChainIterator::operator*() const':
> /home/kdev/kde/src/KDE/kdelibs/kjs/scope_chain.h:118: undefined 
> reference to `KJS::ScopeChainLink::object() const'
> collect2: ld returned 1 exit status
> make[2]: *** [lib/libkjs.so.4.2.0] Error 1
> make[1]: *** [kjs/CMakeFiles/kjs.dir/all] Error 2
> make[1]: *** Waiting for unfinished jobs....
> 
> Don't know enough about this build system to figure this out.
>
> The problem seems to be that JSVariableObject.h is not being included.  
> The object() function called here is defined inline in this header.
> 
> If I directly include this header this particular error goes away but I 
> create a bunch more (which is probably an order of includes thing).

scope_chain.cpp has no definition of ScopeChainLink::next or ::object; 
they are defined (as inline) in JSVariableObject.h, as above, and as per 
the comment in scope_chain.h.

I added '#include "JSVariableObject.h"' to scope_chain.cpp and had no 
problems, so I committed that (as the code was otherwise quite clearly 
broken; that was also before I saw this thread). If that's not the 
correct solution, we need to figure out what is.

Andrew: I added it /last/, please svn up and see if you're still having 
issues, if yes then it was probably order-of-includes (and I guess I 
lucked out getting it right).

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
Person A: It's an ISO standard.
Person B: ...And that means what?
   -- mal (http://theangryadmin.blogspot.com/2008/04/future.html)