kdelibs ktimezonewidget patch

[leo peng]

2008/11/13 Aaron J. Seigo <aseigo at kde.org>

> On Tuesday 11 November 2008, leo peng wrote:
> > Chinese environment, run "kcmshell4 clock", "Indian / Christmas" and
> > "Pacific / Kiritimati" have the same city name at zone list.
> > so time zone list error.
>
> not that it particularly matters to the algorithm in question, but these
> two
> cities don't have this problem here. still ... i can see it occuring, yes.
>
> > Time zone list of the index should be "city +
> > Time zone" in kdelibs/kdeui/widgets/ktimezonewidget.cpp.
> >
> > I add a patch, please see attachment.
>
> the second part of the patch looks ok, but the first part looks wrong.
>
> from reading it, it looks a bit flawed, or at least unecessarily
> inneficient.
> essentially you want Europe/Berlin to become BerlinEurope, right?
>
> in which case ... wouldn't this be easier, more efficient and guaranteed to
> always work:
>
> int separator = contentCity.lastIndexOf('/');
> QString city = continentCity.right(length - separator - 1) +
> continentCity.left(separator);
>
> ?
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Software
>
>
>
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> unsubscribe <<
>
>
I change my first patch,  and fix this problem, please see attachment.
Thank you for your help,  Aaron J.Seigo.
Thank you for your help, Albert.

-- 
 best regards !
----------------------
leopeng
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081113/4199345a/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdelibs-kdeui-widgets-ktimezonewidget.patch
Type: application/octet-stream
Size: 1554 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20081113/4199345a/attachment.obj>
-------------- next part --------------
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<